Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for #17776 "Calling SetBinding after setting a constant value crashes" #17796

Merged
merged 1 commit into from Oct 23, 2023
Merged

Add a test for #17776 "Calling SetBinding after setting a constant value crashes" #17796

merged 1 commit into from Oct 23, 2023

Conversation

StephaneDelcroix
Copy link
Contributor

Description of Change

adding a test that should pass

Issues Fixed

Fixes #17776

@StephaneDelcroix StephaneDelcroix requested review from a team as code owners October 3, 2023 12:56
@StephaneDelcroix StephaneDelcroix changed the base branch from main to net8.0 October 3, 2023 12:57
@Eilon Eilon added the area-xaml XAML, CSS, Triggers, Behaviors label Oct 3, 2023
@samhouts samhouts added this to the .NET 8 GA milestone Oct 5, 2023
@samhouts samhouts added the s/pr-needs-author-input PR needs an update from the author label Oct 5, 2023
@ghost
Copy link

ghost commented Oct 5, 2023

Hi @StephaneDelcroix. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

@PureWeen
Copy link
Member

PureWeen commented Oct 9, 2023

/rebase

@ghost
Copy link

ghost commented Oct 20, 2023

Hi @StephaneDelcroix.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

@ghost ghost added the stale Indicates a stale issue/pr and will be closed soon label Oct 20, 2023
@samhouts
Copy link
Member

/rebase

@rmarinho rmarinho merged commit 33a01c0 into net8.0 Oct 23, 2023
47 checks passed
@rmarinho rmarinho deleted the fix_17776 branch October 23, 2023 11:21
@PureWeen
Copy link
Member

/backport to release/8.0.1xx-rc2.1

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-rc2.1: https://github.com/dotnet/maui/actions/runs/6615463199

@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
@mattleibow mattleibow changed the title Fix 17776 Add a test for #17776 "Calling SetBinding after setting a constant value crashes" Oct 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez approved these changes

@PureWeen PureWeen PureWeen approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-xaml XAML, CSS, Triggers, Behaviors s/pr-needs-author-input PR needs an update from the author stale Indicates a stale issue/pr and will be closed soon
Projects
None yet
Milestone
.NET 8 GA
Development

Successfully merging this pull request may close these issues.

Calling SetBinding after setting a constant value crashes
6 participants
@StephaneDelcroix @PureWeen @samhouts @hartez @Eilon @rmarinho