Only attach log files for current test #17949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BretJohnson
force-pushed
the
dev/bretjohn/fix-appium-test-attachments
branch
5 times, most recently
from
c0c8528
to
df189ff
Compare
jsuarezruiz
previously approved these changes
Oct 11, 2023
Previously we were attaching all log files in the appium log directory, so failed tests in AzDO had a large number of attachments, most unrelated to the test at hand. Fix to only attach files for the current test.
BretJohnson
force-pushed
the
dev/bretjohn/fix-appium-test-attachments
branch
from
df189ff
to
8dbf004
Compare
|
@sbanni - I believe this gets everything, just adding the screenshot and pagesource.txt explicitly put in the log directory, not needing to iterate thru all the log files. But can you please confirm there's nothing that could be missed here. |
sbanni
approved these changes
Oct 11, 2023
rmarinho
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were attaching all log files in the appium log directory, so failed tests in AzDO had a large number of attachments, most unrelated to the test at hand. Fix to only attach files for the current test.