Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WinUI] Fixes window blinking when resizing #18155

Merged
merged 1 commit into from Oct 19, 2023
Merged

[WinUI] Fixes window blinking when resizing #18155

merged 1 commit into from Oct 19, 2023

Conversation

emaf
Copy link
Contributor

@emaf emaf commented Oct 19, 2023 •
edited by samhouts

Description of Change

This bug was introduced by #17069, but the underlying cause is a bug on WinUI that makes the window blink when setting NavigationView.IsPaneVisible = false (https://microsoft.visualstudio.com/DefaultCollection/OS/_workitems/edit/47131770).

After testing the samples attached on the issues the original commit fixed, this change does not seem to re-introduce those issues.

Issues Fixed

Fixes #17724

@emaf
[WinUI] Fixes window blinking when resizing
41915bb 
This bug was introduced by #17069,
but the underlying cause is a bug on WinUI that makes the window blink when
setting `NavigationView.IsPaneVisible = false` (https://microsoft.visualstudio.com/DefaultCollection/OS/_workitems/edit/47131770).

After testing the samples attached on the issues the original commit fixed, this change does not seem to re-introduce those issues.

Fixes #17724
@emaf emaf requested a review from a team as a code owner October 19, 2023 14:35
@emaf emaf added the area/desktop 🖥️ Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls)) label Oct 19, 2023
@PureWeen PureWeen enabled auto-merge (squash) October 19, 2023 14:36
@PureWeen PureWeen removed the request for review from jsuarezruiz October 19, 2023 14:37
@samhouts samhouts linked an issue Oct 19, 2023 that may be closed by this pull request
[regression/8.0.0-rc.1.9171] Window "blinks" when resized #17724
Closed
1 task
@samhouts samhouts added this to the .NET 8 GA milestone Oct 19, 2023
@PureWeen PureWeen merged commit daaaf56 into net8.0 Oct 19, 2023
48 checks passed
@PureWeen PureWeen deleted the dev/ema/winblink branch October 19, 2023 21:49
@emaf
Copy link
Contributor Author

emaf commented Oct 20, 2023

/backport to release/8.0.1xx-rc2.1

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-rc2.1: https://github.com/dotnet/maui/actions/runs/6593410101

@github-actions
Copy link
Contributor

@emaf an error occurred while backporting to release/8.0.1xx-rc2.1, please check the run log for details!

Error: @emaf is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=emaf

@emaf
Copy link
Contributor Author

emaf commented Oct 20, 2023

@samhouts a couple of days ago @PureWeen mentioned I should backport this one to release/8.0.1xx-rc2.1 once its merged, but I don't have permissions :(. I that's still needed, could you do that?

@samhouts
Copy link
Member

/backport to release/8.0.1xx-rc2.1

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-rc2.1: https://github.com/dotnet/maui/actions/runs/6593578878

@github-actions
Copy link
Contributor

@samhouts an error occurred while backporting to release/8.0.1xx-rc2.1, please check the run log for details!

Error: @samhouts is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=samhouts

@samhouts
Copy link
Member

😭 apparently not

@samhouts
Copy link
Member

/backport to release/8.0.1xx-rc2.1

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-rc2.1: https://github.com/dotnet/maui/actions/runs/6593588270

@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Merged
@samhouts
Copy link
Member

haha! what now, bot?? 💪

@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees
No one assigned
Labels
area/desktop 🖥️ Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls)) area/navigation 🧭 NavigationPage platform/windows 🪟
Projects
None yet
Milestone
.NET 8 GA
Development

Successfully merging this pull request may close these issues.

[regression/8.0.0-rc.1.9171] Window "blinks" when resized
4 participants
@emaf @samhouts @PureWeen @jsuarezruiz