Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for concatenating hints in Android #1837

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jul 28, 2021

Description of Change

This copies over the work done here
xamarin/XamarinCommunityToolkit#1381

The logic for concatenating the EditText for Pre API 26 needed to be fixed

In general adding Hints will have degraded experience on Pre API 26

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@PureWeen PureWeen requested a review from rachelkang July 28, 2021 04:22
@PureWeen PureWeen force-pushed the fix_android_accessibilityDelegate branch from 58685ef to c1229ce Compare July 28, 2021 14:29
@PureWeen PureWeen added this to the 6.0.100-preview.7 milestone Jul 28, 2021
@PureWeen PureWeen merged commit 05e97c8 into main Jul 28, 2021
@PureWeen PureWeen deleted the fix_android_accessibilityDelegate branch July 28, 2021 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants