Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8 template tweaks #18379

Merged
merged 6 commits into from Oct 26, 2023
Merged

.NET 8 template tweaks #18379

merged 6 commits into from Oct 26, 2023

Conversation

rachelkang
Copy link
Member

Description of Change

Tweaking templates with new image, colors, styles, courtesy of @davidortinau

@PureWeen PureWeen added this to the .NET 8 GA milestone Oct 26, 2023
@Eilon Eilon added the area/templates 📄 Project templates, Item Templates for Blazor and MAUI label Oct 26, 2023
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the new dotnet bot image be an SVG like before?. Will not scale correctly under all the cases.

Padding="30,0"
VerticalOptions="Center">

<VerticalStackLayout Padding="30,0" Spacing="25">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not important, but I find it weird to have all the properties on the same line here when in the rest we use line breaks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thoughts in mind and have been working on it!

@rachelkang rachelkang marked this pull request as ready for review October 26, 2023 20:59
@rachelkang rachelkang requested a review from a team as a code owner October 26, 2023 20:59
@PureWeen PureWeen enabled auto-merge (squash) October 26, 2023 22:18
@PureWeen PureWeen merged commit e92c7c1 into net8.0 Oct 26, 2023
45 of 47 checks passed
@PureWeen PureWeen deleted the template-tweaks branch October 26, 2023 22:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/templates 📄 Project templates, Item Templates for Blazor and MAUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants