Swap layout namespaces #1838
Swap layout namespaces #1838
Conversation
| namespace Microsoft.Maui.Controls | ||
| { | ||
| public class Grid : GridLayout { } | ||
| public class RelativeLayout : Compatibility.RelativeLayout { } |
There was a problem hiding this comment.
Not sure about the best way yet, but this might cause ambiguity if both namespace are imported.
The only reason to have this is to not break existing code? But maybe that is just something we have to do?
There was a problem hiding this comment.
Can we make the compat ones internal for now?
There was a problem hiding this comment.
Can we make the compat ones internal for now?
Inconsistent accessibility.
There was a problem hiding this comment.
Not sure about the best way yet, but this might cause ambiguity if both namespace are imported.
The only reason to have this is to not break existing code? But maybe that is just something we have to do?
The reason was to avoid breaking hundreds of things in ControlGallery. But if we're really worried about the confusion, I can go update all of those.
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| namespace Microsoft.Maui.Controls | |||
| { | |||
| public class TemplatedView : Layout, IControlTemplated | |||
| public class TemplatedView : Compatibility.Layout, IControlTemplated | |||
There was a problem hiding this comment.
Just a note for RC, we probably should not have a non compat layout derived from a compat one.
However this should be fine technically since this is just a namespace which is arbitrary.
samhouts
added
area-controls-collectionview
samhouts
added
area-controls-radiobutton
Eilon
removed
legacy-area-controls
Move legacy layouts to Microsoft.Maui.Controls.Compatibility; new layouts move to Microsoft.Maui.Controls.
Also adds a StackLayout type to the new layouts which is built out of VerticalStackLayout and HorizontalStackLayout.