[Catalyst] Allow to use a custom WKUIDelegate on WebView

[jsuarezruiz]

Description of Change

Error with a simple fix that I have seen doing triage taking a look to new issues. Allow to use a custom WKUIDelegate on WebView

Issues Fixed

Fixes #18394

[mattleibow]

Do we have any tests for this - even for iOS?

[tekmun]

Line 31 should be || MacCatalyst, not && MacCatalyst.
With AND operation, the conditional statement will not work on iOS and Mac. Please kindly change it! Thanks.

[tekmun]

Do we have any tests for this - even for iOS?

Yes. Use this project.
#17431

Discussion was done in https://stackoverflow.com/questions/77170252/requestcapturemediapermission-for-wkwebview-in-maui-ios/77200328

[mattleibow]

I mean do we have any unit or device tests in Maui? The fact that this PR is green and the wrong condition means that we don't and should. All changes should have a test to ensure that it never breaks again.

[tekmun]

With current main repository, Line 15 on Platforms/iOS/WebViewUIDelegate.cs of this project https://github.com/tekmun/WebViewIssue.git will be called for iOS.

I have not tested it on Mac though. Can someone test whether with the suggested changes, Line 15 on Platforms/iOS/WebViewUIDelegate.cs will be called on Mac/MacCatalyst? In theory, it should.

If it works, then this project https://github.com/tekmun/WebViewIssue.git can be easily converted to become a unit test because it needs to ensure Line 15 on Platforms/iOS/WebViewUIDelegate.cs and Platforms/MacCatalyst/WebViewUIDelegate.cs are called.

[tekmun]

Can this change make it into GA next week?

[tekmun]

This change is not destructive, meaning that it will not affect systems that are working now. It just allows the MacCatalyst app to have the same functionality as the iOS app. Please kindly merge the changes before GA next week. Thanks.

[tekmun]

Any updates on when the merging of this code into the main repository?

[jsuarezruiz]

I mean do we have any unit or device tests in Maui? The fact that this PR is green and the wrong condition means that we don't and should. All changes should have a test to ensure that it never breaks again.

Require a custom WKUIDelegate and handlers, already added a sample in the Gallery.

[tekmun]

Any updates on when the merging of this code into the main repository?
I understand maui is now a nuget package and we can use to download a nightly build. Can I test it out soon?

[tekmun]

It looks like the test case has been added and all checks have passed. Can the reviewers approve this request into the main branch?

[tekmun]

The requested change has not been reflected in the main branch. Why is request marked as DONE?

[jsuarezruiz]

Yay, build is passing. Could we get another review here?

[PureWeen]

I don't think we need this

[PureWeen]

I don't think this does anything in our code

Semi-confusingly

We already build everything marked as IOS for MACCatalyst
https://github.com/dotnet/maui/blob/main/src/MultiTargeting.targets#L99-L102

I'm not really sure what the users problem is but I don't think this will fix anything for them.

I don't quite understand on the repro, why they are setting the delegate inside a "BeginInvoke" call.

Like, if I check the type of the UIDelegate it's definitely already being replaced

you can also see it here that it's already set

[PureWeen]

#18483 (comment)