Reinstate MediaPicker.CaptureVideo for Android (API 33) #18620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
t/bug
rmarinho
approved these changes
Nov 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
As reported in #17977
CaptureVideono longer works for API 33 and up. It seems like something has changed for Android in how this works. Originally, the code would go throughIntermediateActivity.OnActivityResultbut on Android 13 this always has the parameter valueresultCode == Result.Canceled. Changing the code to use the inline callback function inMediaPickerand not depend onIntermediateActivityseems to work.Interesting enough, for
CapturePhotothis way already changed, but for video we didn't seem to have done that. This change makesCaptureVideoinline withCapturePhotoand makes it work again for all Android versions.Issues Fixed
Fixes #17977