Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to stable versions of .NET 8 #18732

Merged
merged 2 commits into from Nov 18, 2023
Merged

Update to stable versions of .NET 8 #18732

merged 2 commits into from Nov 18, 2023

Conversation

mattleibow
Copy link
Member

Description of Change

.NET 8 is OUT!

@mattleibow mattleibow requested a review from a team as a code owner November 14, 2023 17:35
PureWeen
PureWeen previously approved these changes Nov 14, 2023
View reviewed changes
Redth
Redth previously approved these changes Nov 14, 2023
View reviewed changes
@mattleibow

This comment was marked as outdated.

Sign in to view
@azure-pipelines Azure Pipelines

This comment was marked as outdated.

Sign in to view
@mattleibow

This comment was marked as outdated.

Sign in to view
@azure-pipelines Azure Pipelines

This comment was marked as outdated.

Sign in to view
@Eilon Eilon added the area/infrastructure 🏗️ CI, Maestro / Coherency label Nov 14, 2023
@mattleibow

This comment was marked as outdated.

Sign in to view
@azure-pipelines Azure Pipelines

This comment was marked as outdated.

Sign in to view
@mattleibow

This comment was marked as outdated.

Sign in to view
@azure-pipelines Azure Pipelines

This comment was marked as outdated.

Sign in to view
@mattleibow

This comment was marked as outdated.

Sign in to view
@azure-pipelines Azure Pipelines

This comment was marked as outdated.

Sign in to view
@mattleibow
Copy link
Member Author

Build is failing with a bunch of new warnings in Tizen. They are working on fixing that and then I will rebase. No rush to merge this today.

@jsuarezruiz
Copy link
Contributor

The build is failing mostly because there are deprecated APIs used on Tizen Essentials

D:\a\_work\1\s\src\Essentials\src\Permissions\Permissions.tizen.cs(62,8): error CS0618: 'PrivacyPrivilegeManager' is obsolete: 'Deprecated in API11, will be removed in API13. This API will be removed without any alternatives.' [D:\a\_work\1\s\src\Essentials\src\Essentials.csproj::TargetFramework=net8.0-tizen]
D:\a\_work\1\s\src\Essentials\src\Permissions\Permissions.tizen.cs(62,8): error CS0618: 'PrivacyPrivilegeManager.GetResponseContext(string)' is obsolete: 'Deprecated in API11, will be removed in API13. This API will be removed without any alternatives.' [D:\a\_work\1\s\src\Essentials\src\Essentials.csproj::TargetFramework=net8.0-tizen]
D:\a\_work\1\s\src\Essentials\src\Permissions\Permissions.tizen.cs(69,8): error CS0618: 'PrivacyPrivilegeManager' is obsolete: 'Deprecated in API11, will be removed in API13. This API will be removed without any alternatives.' [D:\a\_work\1\s\src\Essentials\src\Essentials.csproj::TargetFramework=net8.0-tizen]
D:\a\_work\1\s\src\Essentials\src\Permissions\Permissions.tizen.cs(69,8): error CS0618: 'PrivacyPrivilegeManager.RequestPermission(string)' is obsolete: 'Deprecated in API11, will be removed in API13. This API will be removed without any alternatives.' [D:\a\_work\1\s\src\Essentials\src\Essentials.csproj::TargetFramework=net8.0-tizen]
D:\a\_work\1\s\src\Essentials\src\Permissions\Permissions.tizen.cs(68,8): error CS0618: 'PrivacyPrivilegeManager.ResponseContext.ResponseFetched' is obsolete: 'Deprecated in API11, will be removed in API13. This API will be removed without any alternatives.' [D:\a\_work\1\s\src\Essentials\src\Essentials.csproj::TargetFramework=net8.0-tizen]
D:\a\_work\1\s\src\Essentials\src\Permissions\Permissions.tizen.cs(71,8): error CS0618: 'PrivacyPrivilegeManager.ResponseContext.ResponseFetched' is obsolete: 'Deprecated in API11, will be removed in API13. This API will be removed without any alternatives.' [D:\a\_work\1\s\src\Essentials\src\Essentials.csproj::TargetFramework=net8.0-tizen]

@mattleibow mattleibow dismissed stale reviews from Redth and PureWeen via bc4d150 November 15, 2023 15:21
@mattleibow mattleibow force-pushed the dev/stable branch 2 times, most recently from bc4d150 to fd46893 Compare November 15, 2023 20:01
@mattleibow mattleibow requested a review from a team as a code owner November 15, 2023 20:01
@JoonghyunCho
Copy link
Contributor

@mattleibow Thanks for updating manifest. and please keep disabling CS0618 for those 3 files. There would be no alternatives for them.

@mattleibow mattleibow force-pushed the dev/stable branch 4 times, most recently from 0dd9674 to 4ec9272 Compare November 17, 2023 12:18
@mattleibow
Copy link
Member Author

mattleibow commented Nov 17, 2023 •
edited

@JoonghyunCho I see the build fails when using .NET 8 (and Tizen SDK 7.0.129) but the project is targeting .NET 7 (net7.0-tizen).

The Tizen manifests always use the same Tizen SDK for all TFMs, so 7.0.129 is used for net7.0-tizen AND net8.0-tizen. I am not sure if that is a design feature? I do not think there is any issues to doing that, but maybe the tasks get more complex as they have to understand different .NET versions.

For now, I am disabling .NET 7 builds using the .NET 8 SDK.

I opened an issue to track this: #18837 and it has a lot more info as well of some potential fixes/comments.

@mattleibow mattleibow mentioned this pull request Nov 17, 2023
Open
@mattleibow mattleibow force-pushed the dev/stable branch 2 times, most recently from 297c26f to 02296eb Compare November 17, 2023 14:17
@JoonghyunCho
Copy link
Contributor

please update SamsungTizenSdkPackageVersion to 8.0.130.

@rmarinho rmarinho enabled auto-merge (squash) November 18, 2023 22:52
@rmarinho rmarinho merged commit 1b20055 into main Nov 18, 2023
47 checks passed
@rmarinho rmarinho deleted the dev/stable branch November 18, 2023 23:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen PureWeen left review comments

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area/infrastructure 🏗️ CI, Maestro / Coherency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mattleibow @jsuarezruiz @JoonghyunCho @Redth @rmarinho @PureWeen @Eilon