-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Accessibility traits to controls that have TapGestureRecognizers #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3dec8c
to
857713a
Compare
857713a
to
53c720d
Compare
rachelkang
reviewed
Aug 2, 2021
src/Controls/src/Core/Platform/Android/Extensions/SemanticExtensions.cs
Outdated
Show resolved
Hide resolved
rachelkang
reviewed
Aug 2, 2021
src/Controls/src/Core/Platform/Android/Extensions/SemanticExtensions.cs
Outdated
Show resolved
Hide resolved
rachelkang
reviewed
Aug 2, 2021
rachelkang
reviewed
Aug 2, 2021
@@ -14,5 +18,99 @@ public static void SetSemanticFocus(this IFrameworkElement element) | |||
|
|||
view.SendAccessibilityEvent(EventTypes.ViewFocused); | |||
} | |||
|
|||
public static void UpdateSemanticNodeInfo(this View nativeView, IView virtualView, AccessibilityNodeInfoCompat? info) | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
rachelkang
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If users attach a touch gesture recognizer that will activate with a single touch then we add accessibility traits that will inform readers that the element is clickable.
Move all the semantic processing logic to extension methods to allow users to reuse if they need to
Make the MauiAccessibilityDelegate public for reuse
Adds an
AccessibilityDelegateCompatWrapper
that wraps an already assigned AccessibilityDelegateCompat. This allows you to easily retain the behavior of the current delegate and then add on to itAlternative PR to
#1861
Additions made
PR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.