Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Ignore flaky android device tests #18905

Merged
merged 2 commits into from Nov 22, 2023
Merged

[tests] Ignore flaky android device tests #18905

merged 2 commits into from Nov 22, 2023

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Nov 20, 2023 •
edited

Description of Change

Ignore tests while we are working to port them:

#18747
#18961

@rmarinho rmarinho requested a review from a team as a code owner November 20, 2023 15:24
@rmarinho rmarinho changed the title [tests] Ignore flacky androdi tests [tests] Ignore flacky android tests Nov 20, 2023
@rmarinho rmarinho changed the title [tests] Ignore flacky android tests [tests] Ignore flaky android tests Nov 20, 2023
@rmarinho rmarinho added area/testing Unit tests, device tests testing-flakiness labels Nov 20, 2023
@rmarinho rmarinho requested review from PureWeen and removed request for StephaneDelcroix November 20, 2023 15:47
PureWeen
PureWeen requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just deleting these I think is fine so long as we have tracking issues on our board for replacing them.

@jsuarezruiz
Copy link
Contributor

Just deleting these I think is fine so long as we have tracking issues on our board for replacing them.

yes, we already have an open PR to replace this one by an UITEST.

@rmarinho rmarinho mentioned this pull request Nov 22, 2023
Open
@rmarinho rmarinho changed the title [tests] Ignore flaky android tests [tests] Ignore flaky android device tests Nov 22, 2023
@PureWeen PureWeen enabled auto-merge (squash) November 22, 2023 18:53
@PureWeen PureWeen merged commit 9546823 into main Nov 22, 2023
47 checks passed
@PureWeen PureWeen deleted the ignore-android-tests branch November 22, 2023 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@hartez hartez Awaiting requested review from hartez hartez is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area/testing Unit tests, device tests platform/android 🤖 testing-flakiness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rmarinho @jsuarezruiz @PureWeen @samhouts