Update ShellSectionRenderer.cs #18945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix crash navigating in Shell and trying to get the navbar visibility
ghost
added
the
|
Hey there @1c3f0x84! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
hartez
previously approved these changes
Nov 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jfversluis
requested changes
Dec 1, 2023
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs
Show resolved
Hide resolved
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
jfversluis
reviewed
Dec 2, 2023
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
approved these changes
Dec 2, 2023
|
Thank you for your contribution @1c3f0x84 ! |
|
I just stumbled on this bug myself in .NET 7. Is there a workaround, or is it a case of waiting for the next service release? |
Tried to manually implement ShellSectionRenderer with proper fix but some members and methods are internal visible in MAUI assembly. Would be great if someone found solution for this. |
|
Just encountered this in .NET 8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash navigating in Shell and trying to get the navbar visibility
Fixes Random crashes on iOS when navigating
Fixes #18153