Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for button cornerradius 0 on android #18959

Merged
merged 2 commits into from Dec 8, 2023
Merged

Fix for button cornerradius 0 on android #18959

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10f31b4
Also setcornerradius if radius is 0. It didn't go into this block and…
Nov 22, 2023
89053a2
Added a devicetest for cornerradius on Android
Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/src/Platform/Android/ButtonExtensions.cs
View file
Open in desktop
Expand Up @@ -96,7 +96,7 @@ internal static void UpdateBorderDrawable(this MaterialButton platformView, IBut
if (button.StrokeThickness > 0)
mauiDrawable.SetBorderWidth(button.StrokeThickness);
Comment on lines 96 to 97
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need to be changed? Sure, this PR is not meant for both because of the issue, but maybe both can be fixed at the same time? Not sure if you observed strange things with borders?

If you would like to keep these 2 things separate, the that is good. I'll just create an issue so we don't miss it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One problem at a time, man.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this as well, but didn't find an issue related to it. So I am unsure if strange things happen here, to be checked.


if (button.CornerRadius > 0)
if (button.CornerRadius >= 0)
mauiDrawable.SetCornerRadius(button.CornerRadius);
else
{
Expand Down