Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Add PressVolumeUp and PressVolumeDown methods to UITest #19131

Merged
merged 4 commits into from Dec 4, 2023

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Nov 30, 2023

Description of Change

We have gaps in our UITests with appium compared to Xamarin.UITest. We continue adding options and filling gaps.
This PR include methods to manange the volume keys.

  • PressVolumeUp
  • PressVolumeDown

@jsuarezruiz jsuarezruiz added t/housekeeping ♻︎ area/testing Unit tests, device tests testing-legacy-ui-tests Issues/PRs that are associated with transitioning our legacy UI Tests to Appium labels Nov 30, 2023
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner November 30, 2023 11:20
/// Presses the volume down button on the device.
/// </summary>
/// <param name="app"></param>
public static void PressVolumeDown(this IApp app)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// Presses the volume up button on the device.
/// </summary>
/// <param name="app"></param>
public static void PressVolumeUp(this IApp app)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz jsuarezruiz changed the title Added volume UITest actions [Testing] Add PressVolumeUp and PressVolumeDown methods to UITest Nov 30, 2023
@jsuarezruiz
Copy link
Contributor Author

The name of the added methods as well as their parameters are the same ones used in Xamarin.UITest, thinking of facilitating the port of tests.

@jsuarezruiz jsuarezruiz requested review from jfversluis and rmarinho and removed request for hartez and mattleibow November 30, 2023 11:28
jfversluis
jfversluis previously approved these changes Dec 1, 2023
@jfversluis jfversluis merged commit 1f21047 into main Dec 4, 2023
47 checks passed
@jfversluis jfversluis deleted the ui-test-volume branch December 4, 2023 10:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/testing Unit tests, device tests t/housekeeping ♻︎ testing-legacy-ui-tests Issues/PRs that are associated with transitioning our legacy UI Tests to Appium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants