New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Add PressVolumeUp and PressVolumeDown methods to UITest #19131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/housekeeping ♻︎
area/testing
Unit tests, device tests
testing-legacy-ui-tests
Issues/PRs that are associated with transitioning our legacy UI Tests to Appium
labels
Nov 30, 2023
jsuarezruiz
commented
Nov 30, 2023
/// Presses the volume down button on the device. | ||
/// </summary> | ||
/// <param name="app"></param> | ||
public static void PressVolumeDown(this IApp app) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsuarezruiz
commented
Nov 30, 2023
/// Presses the volume up button on the device. | ||
/// </summary> | ||
/// <param name="app"></param> | ||
public static void PressVolumeUp(this IApp app) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsuarezruiz
changed the title
Added volume UITest actions
[Testing] Add PressVolumeUp and PressVolumeDown methods to UITest
Nov 30, 2023
The name of the added methods as well as their parameters are the same ones used in Xamarin.UITest, thinking of facilitating the port of tests. |
jsuarezruiz
requested review from
jfversluis and
rmarinho
and removed request for
hartez and
mattleibow
November 30, 2023 11:28
jfversluis
previously approved these changes
Dec 1, 2023
jfversluis
approved these changes
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/testing
Unit tests, device tests
t/housekeeping ♻︎
testing-legacy-ui-tests
Issues/PRs that are associated with transitioning our legacy UI Tests to Appium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We have gaps in our UITests with appium compared to Xamarin.UITest. We continue adding options and filling gaps.
This PR include methods to manange the volume keys.