[Blazor] Fix concurrency problem in Android builds #19140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable static web assets on nested Rid builds as its not necessary it runs there. * The outer build already collects the assets and transforms them into Maui assets.
Eilon
previously approved these changes
Nov 30, 2023
src/BlazorWebView/src/Maui/build/Microsoft.AspNetCore.Components.WebView.Maui.props
Show resolved
Hide resolved
rmarinho
previously requested changes
Nov 30, 2023
There was a problem hiding this comment.
Seems it's still failing
D:\a\_work\1\s\bin\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.References.targets(16,5): error : Manifest file at 'obj\Release\net8.0-android\android-x86\staticwebassets.build.json' not found. [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net8.0-android]
D:\a\_work\1\s\bin\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.References.targets(16,5): error : Manifest file at 'obj\Release\net8.0-android\android-arm64\staticwebassets.build.json' not found. [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net8.0-android]
D:\a\_work\1\s\bin\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.References.targets(16,5): error : Manifest file at 'obj\Release\net8.0-android\android-x64\staticwebassets.build.json' not found. [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net8.0-android]
D:\a\_work\1\s\bin\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.References.targets(16,5): error : Manifest file at 'obj\Release\net8.0-android\android-arm\staticwebassets.build.json' not found. [D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net8.0-android]
D:\a\_work\1\s\bin\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.References.targets(16,5): error : Manifest file at 'obj\Release\net8.0-android\android-x86\staticwebassets.build.json' not found. [D:\a\_work\1\s\src\BlazorWebView\tests\MauiDeviceTests\MauiBlazorWebView.DeviceTests.csproj::TargetFramework=net8.0-android]
D:\a\_work\1\s\bin\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.References.targets(16,5): error : Manifest file at 'obj\Release\net8.0-android\android-x64\staticwebassets.build.json' not found. [D:\a\_work\1\s\src\BlazorWebView\tests\MauiDeviceTests\MauiBlazorWebView.DeviceTests.csproj::TargetFramework=net8.0-android]
D:\a\_work\1\s\bin\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.References.targets(16,5): error : Manifest file at 'obj\Release\net8.0-android\android-arm\staticwebassets.build.json' not found. [D:\a\_work\1\s\src\BlazorWebView\tests\MauiDeviceTests\MauiBlazorWebView.DeviceTests.csproj::TargetFramework=net8.0-android]
D:\a\_work\1\s\bin\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.References.targets(16,5): error : Manifest file at 'obj\Release\net8.0-android\android-arm64\staticwebassets.build.json' not found. [D:\a\_work\1\s\src\BlazorWebView\tests\MauiDeviceTests\MauiBlazorWebView.DeviceTests.csproj::TargetFramework=net8.0-android]
The test was not importing the props file. Hopefully the latest change will address it |
|
This should also close this #11872 |
rmarinho
approved these changes
Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/aspnetcore#52460