Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct nullable annotations on IMediaPicker #19157

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Correct nullable annotations on IMediaPicker #19157

merged 4 commits into from
Dec 13, 2023

Conversation

jfversluis
Copy link
Member

Description of Change

Adds the correct nullable annotations on IMediaPicker

Issues Fixed

Fixes #17320

@jfversluis jfversluis added t/bug Something isn't working t/breaking 💥 area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info labels Dec 1, 2023
@jfversluis jfversluis requested a review from a team as a code owner December 1, 2023 13:28
@ghost
Copy link

ghost commented Dec 1, 2023

🚨 API change(s) detected @davidbritch FYI

@rmarinho
Copy link
Member

rmarinho commented Dec 4, 2023

Are we fine with changing the API on a sr1 ?

@mattleibow
Copy link
Member

This is technically breaking, but our guides do allow us some leeway if we have made a mistake or missed some: https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/api-guidelines/nullability.md#breaking-change-guidance

Not sure for sure tho.

@ErisApps
Copy link

ErisApps commented Dec 7, 2023

Hii, given that this PR is related to the API of IMediaPicker, I kindly would like to bring up the inconsistency of said API regarding cancellation, for which I had already created another issue (#18889), as the current documentation for the return type don't seem to match with the actual behavior across all platforms. 🙂

@jfversluis
Copy link
Member Author

@ErisApps thank you for that! With this change in mind, what would still need to be fixed according to you?

@jfversluis jfversluis merged commit 9b99433 into main Dec 13, 2023
47 checks passed
@jfversluis jfversluis deleted the fix-17320 branch December 13, 2023 08:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartyIX MartyIX MartyIX left review comments

@mattleibow mattleibow mattleibow approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info t/breaking 💥 t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong nullable annotations in IMediaPicker
6 participants
@jfversluis @rmarinho @mattleibow @ErisApps @MartyIX @tj-devel709