Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Add scroll methods to UITest #19181

Merged
merged 4 commits into from Dec 11, 2023
Merged

[Testing] Add scroll methods to UITest #19181

merged 4 commits into from Dec 11, 2023

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Add scroll methods to UITest.

  • ScrollDown
  • ScrollLeft
  • ScrollUp
  • ScrollRight

@jsuarezruiz jsuarezruiz added t/housekeeping ♻︎ area/testing Unit tests, device tests testing-legacy-ui-tests Issues/PRs that are associated with transitioning our legacy UI Tests to Appium labels Dec 4, 2023
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner December 4, 2023 10:40
public void ScrollUpAndDownWithGestures()
{
App.ScrollDown("thescroller", ScrollStrategy.Gesture, 0.75);
App.Screenshot("Element scrolled down");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test to validate the added methods (scroll with gestures)
scroll-gesture-uitest

/// <param name="swipePercentage">How far across the element to swipe (from 0.0 to 1.0).</param>
/// <param name="swipeSpeed">The speed of the gesture.</param>
/// <param name="withInertia">Whether swipes should cause inertia.</param>
public static void ScrollUp(this IApp app, string marked, ScrollStrategy strategy = ScrollStrategy.Auto, double swipePercentage = 0.67, int swipeSpeed = 500, bool withInertia = true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// <param name="swipePercentage">How far across the element to swipe (from 0.0 to 1.0).</param>
/// <param name="swipeSpeed">The speed of the gesture.</param>
/// <param name="withInertia">Whether swipes should cause inertia.</param>
public static void ScrollDown(this IApp app, string marked, ScrollStrategy strategy = ScrollStrategy.Auto, double swipePercentage = 0.67, int swipeSpeed = 500, bool withInertia = true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jfversluis
jfversluis previously approved these changes Dec 5, 2023
@jfversluis
Copy link
Member

/rebase

@jfversluis jfversluis merged commit 089eacc into main Dec 11, 2023
47 checks passed
@jfversluis jfversluis deleted the uitest-scroll-actions branch December 11, 2023 13:32
@jsuarezruiz jsuarezruiz self-assigned this Dec 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/testing Unit tests, device tests t/housekeeping ♻︎ testing-legacy-ui-tests Issues/PRs that are associated with transitioning our legacy UI Tests to Appium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants