New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Add scroll methods to UITest #19181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/housekeeping ♻︎
area/testing
Unit tests, device tests
testing-legacy-ui-tests
Issues/PRs that are associated with transitioning our legacy UI Tests to Appium
labels
Dec 4, 2023
jsuarezruiz
commented
Dec 4, 2023
public void ScrollUpAndDownWithGestures() | ||
{ | ||
App.ScrollDown("thescroller", ScrollStrategy.Gesture, 0.75); | ||
App.Screenshot("Element scrolled down"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsuarezruiz
commented
Dec 4, 2023
/// <param name="swipePercentage">How far across the element to swipe (from 0.0 to 1.0).</param> | ||
/// <param name="swipeSpeed">The speed of the gesture.</param> | ||
/// <param name="withInertia">Whether swipes should cause inertia.</param> | ||
public static void ScrollUp(this IApp app, string marked, ScrollStrategy strategy = ScrollStrategy.Auto, double swipePercentage = 0.67, int swipeSpeed = 500, bool withInertia = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsuarezruiz
commented
Dec 4, 2023
/// <param name="swipePercentage">How far across the element to swipe (from 0.0 to 1.0).</param> | ||
/// <param name="swipeSpeed">The speed of the gesture.</param> | ||
/// <param name="withInertia">Whether swipes should cause inertia.</param> | ||
public static void ScrollDown(this IApp app, string marked, ScrollStrategy strategy = ScrollStrategy.Auto, double swipePercentage = 0.67, int swipeSpeed = 500, bool withInertia = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jfversluis
reviewed
Dec 5, 2023
jfversluis
previously approved these changes
Dec 5, 2023
/rebase |
jfversluis
force-pushed
the
uitest-scroll-actions
branch
from
December 5, 2023 15:21
4904e52
to
3d10bff
Compare
jfversluis
approved these changes
Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/testing
Unit tests, device tests
t/housekeeping ♻︎
testing-legacy-ui-tests
Issues/PRs that are associated with transitioning our legacy UI Tests to Appium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add scroll methods to UITest.