Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing semantic tests on iOS #19344

Merged
merged 1 commit into from Dec 12, 2023
Merged

Disable failing semantic tests on iOS #19344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBaseOfT.Tests.cs
View file
Open in desktop
Expand Up @@ -78,7 +78,11 @@ public virtual async Task SetVisibility(Visibility visibility)
Assert.Equal(view.Visibility, id);
}

[Fact(DisplayName = "Setting Semantic Description makes element accessible")]
[Fact(DisplayName = "Setting Semantic Description makes element accessible"
#if IOS
, Skip = "This is failing on iOS: https://github.com/dotnet/maui/issues/19122"
#endif
)]
public async virtual Task SettingSemanticDescriptionMakesElementAccessible()
{
var view = new TStub();
Expand All @@ -90,7 +94,11 @@ public async virtual Task SettingSemanticDescriptionMakesElementAccessible()
Assert.True(important);
}

[Fact(DisplayName = "Setting Semantic Hint makes element accessible")]
[Fact(DisplayName = "Setting Semantic Hint makes element accessible"
#if IOS
, Skip = "This is failing on iOS: https://github.com/dotnet/maui/issues/19122"
#endif
)]
public async virtual Task SettingSemanticHintMakesElementAccessible()
{
var view = new TStub();
Expand Down Expand Up @@ -128,7 +136,11 @@ public async Task SetSemanticHint()
Assert.Equal(view.Semantics.Hint, id);
}

[Fact(DisplayName = "Semantic Heading is set correctly")]
[Fact(DisplayName = "Semantic Heading is set correctly"
#if IOS
, Skip = "This is failing on iOS: https://github.com/dotnet/maui/issues/19122"
#endif
)]
public async Task SetSemanticHeading()
{
var view = new TStub();
Expand Down