[X] Change the default value for xaml-comp #19390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
previously approved these changes
Dec 13, 2023
simonrozsival
previously approved these changes
Dec 13, 2023
StephaneDelcroix
dismissed stale reviews from simonrozsival and mattleibow
via
1a87a17
StephaneDelcroix
force-pushed
the
xaml-comp_default
branch
from
d546ba9
to
1a87a17
Compare
| @@ -295,7 +295,7 @@ static bool TryParseXaml(SourceText text, string uid, Compilation compilation, A | |||
|
|
|||
| if (rootClass != null) | |||
| XmlnsHelper.ParseXmlns(rootClass.Value, out rootType, out rootClrNamespace, out var rootAsm, out var targetPlatform); | |||
| else if (hasXamlCompilationProcessingInstruction) | |||
| else if (hasXamlCompilationProcessingInstruction && root.NamespaceURI == XamlParser.MauiUri) | |||
There was a problem hiding this comment.
added this check to make sure the file was valid Xaml, but it ain't right, even if it works
The default value for the xaml-comp processing instruction used to be false, meaning the a XAML ResourceDictionary without code-behind wasn't compiled by XamlC unless the <?xaml-comp compile="true" ?> processing instruction was specified. From now on, we will compile all XAML-only RD, unless the <?xaml-comp compile="false" ?> is set. Thsi will help with performance and trimming
StephaneDelcroix
force-pushed
the
xaml-comp_default
branch
from
1a87a17
to
70cd5bc
Compare
mattleibow
approved these changes
Dec 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for the xaml-comp processing instruction used to be false, meaning that a XAML ResourceDictionary without code-behind wasn't compiled by XamlC unless the processing instruction was specified.
From now on, we will compile all XAML-only RD, unless the is set.
Thsi will help with performance and trimming
Description of Change
Issues Fixed
Fixes #