Removes dead code from type conversion #19436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed code would only run if `converter` was not null. But in that case the if on line 166 would match and it would return from the method. So the removed code can only be reached if `converter` is null.
ghost
added
the
|
Hey there @vitek-karas! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
PureWeen
requested review from
StephaneDelcroix
and removed request for
jfversluis and
mattleibow
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
added
area/Xaml </>
mattleibow
approved these changes
Jan 19, 2024
|
I wonder if it is better to still remove this dead code, then rather wrap the try in an if instead of the type convert? Makes it more readable and removes an unnecesary cast. |
|
I believe this code was there to handle System.ComponentModel.TypeConverter in addition of XF TypeConverter, but we a quick check indicates we got rid of that |
Aroz1312
approved these changes
Jan 19, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Feb 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The removed code would only run if
converterwas not null. But in that case the if on line 166 would match and it would return from the method. So the removed code can only be reached ifconverteris null.