[testing] Enable a way to test on real devices #19492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
github-actions
bot
force-pushed
the
maui-testing
branch
from
6b504a9
to
0d9d64a
Compare
rmarinho
force-pushed
the
maui-testing
branch
from
dd6fdf5
to
059ba24
Compare
rmarinho
requested review from
jfversluis
and removed request for
StephaneDelcroix
rmarinho
commented
Dec 20, 2023
| string DOTNET_PLATFORM = TEST_DEVICE.ToLower().Contains("simulator") ? "iossimulator-x64" : "ios-arm64"; | ||
| string DOTNET_PLATFORM = TEST_DEVICE.ToLower().Contains("simulator") ? | ||
| $"iossimulator-{System.Runtime.InteropServices.RuntimeInformation.OSArchitecture.ToString().ToLower()}" | ||
| : $"ios-arm64"; |
There was a problem hiding this comment.
If it's a device we always want arm64
There was a problem hiding this comment.
Hm I thought we had this architecture stuff in here already? Maybe I'm thinking of that ARM PR I still need to finish...
rmarinho
commented
Dec 20, 2023
| @@ -93,7 +98,16 @@ void Cleanup() | |||
| Information("No simulators found to delete."); | |||
| return; | |||
| } | |||
| var xharness = sims.Where(s => s.Name.Contains("XHarness")).ToArray(); | |||
| var simulatorName = "XHarness"; | |||
| if(iosVersion.Contains("17")) | |||
There was a problem hiding this comment.
I think we need to open a bug on. xharness about this it seems it doesn't have the "Created by XHarness" if it's a iPhone 15. this leads to sometimes delete existing simulators.
rmarinho
commented
Dec 20, 2023
| @@ -144,7 +144,7 @@ stages: | |||
| windows: $(System.DefaultWorkingDirectory)/src/Core/tests/DeviceTests/Core.DeviceTests.csproj | |||
| - name: controls | |||
| desc: Controls | |||
| androidApiLevelsExclude: [25] # Ignore for now API25 since the runs's are not stable | |||
| androidApiLevelsExclude: [27, 25] # Ignore for now API25 since the runs's are not stable | |||
There was a problem hiding this comment.
Disable API27 since is not stable
jfversluis
approved these changes
Dec 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Enables the cake scripts to test on real devices.
On
iosVersions: [ 'simulator-16.4','simulator-15.5','simulator-14.5' ]one would be able to say
iosVersions: [ 'simulator-16.4','simulator-15.5','device-16.5', 'device-17' ]Work related with #19255