Break ControlsHeadlessTestRunner.RunTestsAsync method when discovering tests
#19559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
platform/windows 🪟
area/testing
jfversluis
changed the title
ControlsHeadlessTestRunner.RunTestsAsync method when discovering testsControlsHeadlessTestRunner.RunTestsAsync method when discovering tests
rmarinho
approved these changes
Dec 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of limitations on Windows/WinUI we have a bit of a complicated setup to run our tests there. There is a limit on the number of windows (actual desktop windows) we can spawn, if we hit the limit, the app crashes. That's why we broke up the running of tests per category.
The process is roughly: the Windows app gets started with a startup argument of -1, that means: go discover the tests. Then, each consecutive run will have a number starting at 0 and looping until the count of the categories discovered.
This was a bit flaky as can be seen in the linked issue. Seemingly because we weren't stopping the running of tests with the -1 option where we just want to discover the tests. Adding this condition makes this more stable.
Fixes #19463