Resizetizer Regex Fix #19600
Merged
Resizetizer Regex Fix #19600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#19574 Fixed Resizetizer Regex not allowing single letter characters. "a" I also fixed another part of the regex where a the following input was allowed when it shouldnt have. "a=" The regex is based off the error given by regex. Requirements are: 1. First char should be a lowercase letter between a-z 2. The rest can be a lowercase letter or a number 0-9 or an underscore. 3. Lastly, the last character is NOT an underscore.
Resizetizer Regex Fix
ghost
added
the
|
Hey there @Xenooooon! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Eilon
added
the
area/single project ☝️
|
@mattleibow any particular reason this was done? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was done because I understand all the simple and non-dodgy concepts about regex. 🤣 @Xenooooon thanks for the change! Is it possible to add some of your test cases to src\SingleProject\Resizetizer\test\UnitTests\FilenameTests.cs? |
|
@dotnet-policy-service agree |
|
@mattleibow Done! |
|
/azp run |
mattleibow
approved these changes
Jan 21, 2024
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19574
Fixed Resizetizer Regex not allowing single letter characters. "a"
I also fixed another part of the regex where a the following input was allowed when it shouldnt have. "a="
The regex is based off the error given by regex. Requirements are:
Description of Change
Changed the regex from
^[a-z]+[a-z0-9_]{0,}[^_]$to
^[a-z]([a-z0-9_]*[a-z0-9])?$Issues Fixed
Fixes #19574