Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalyst] Allow setting of CancelButtonColor on SearchBar when using Mac Idiom #19838

Merged
merged 1 commit into from Jan 12, 2024

Conversation

mikeparker104
Copy link
Contributor

Description of Change

Update to SearchBarExtensions so UpdateCancelButton sets the TintColor on the Cancel UIButton when using Mac idiom. Device test added verifying the changes for Mac Catalyst and iOS.

Issues Fixed

Fixes #18110

@mikeparker104 mikeparker104 added platform/macOS 🍏 macOS / Mac Catalyst area/controls 🎮 Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels Jan 11, 2024
@mikeparker104 mikeparker104 self-assigned this Jan 11, 2024
@mikeparker104 mikeparker104 requested a review from a team as a code owner January 11, 2024 20:04
@rmarinho
Copy link
Member

But this test will not actually run right? We have to manual change the idiom and check?

@mikeparker104
Copy link
Contributor Author

But this test will not actually run right? We have to manual change the idiom and check?

Correct. Shall we create an issue for device testing Mac Idiom similar to #19288?

@jsuarezruiz
Copy link
Contributor

But this test will not actually run right? We have to manual change the idiom and check?

What would be the best option here? Create a Controls.DeviceTest.MacIdiom project with specific tests for Mac user interface idiom?
https://learn.microsoft.com/en-us/dotnet/maui/mac-catalyst/user-interface-idiom?view=net-maui-8.0

@mikeparker104
Copy link
Contributor Author

But this test will not actually run right? We have to manual change the idiom and check?

What would be the best option here? Create a Controls.DeviceTest.MacIdiom project with specific tests for Mac user interface idiom? https://learn.microsoft.com/en-us/dotnet/maui/mac-catalyst/user-interface-idiom?view=net-maui-8.0

@jsuarezruiz created issue #19856 to consider future approach to device testing using Mac Idiom 👍

@mikeparker104 mikeparker104 merged commit d44f3c7 into dotnet:main Jan 12, 2024
47 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/controls 🎮 Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor platform/macOS 🍏 macOS / Mac Catalyst
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mac Catalyst] Setting CancelButtonColor on SearchBar has no effect when using Mac Idiom
3 participants