Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal page push in immersive mode #19903

Merged
merged 3 commits into from Feb 16, 2024
Merged

Conversation

PavloLukianets
Copy link
Contributor

@PavloLukianets PavloLukianets commented Jan 15, 2024

Issues Fixed

Fixes #10364

Description of Change

Fix modal page push in immersive mode

untitled.webm

@PavloLukianets PavloLukianets requested a review from a team as a code owner January 15, 2024 14:53
@ghost ghost added the community ✨ Community Contribution label Jan 15, 2024
@ghost
Copy link

ghost commented Jan 15, 2024

Hey there @PavloLukianets! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis

This comment was marked as off-topic.

This comment was marked as off-topic.

@jfversluis

This comment was marked as off-topic.

This comment was marked as off-topic.

@PavloLukianets
Copy link
Contributor Author

PavloLukianets commented Jan 16, 2024

Changed the pr a bit, less additional calls and code now. Also, i was thinking about fixing #18033 , but the only way for it to work that i've figured out is to check if the bar's color is Transparent, but i highly doubt the team will let this hack through) Unfortunately there is no such method such as WindowCompat.GetDecorFitsSystemWindows() that we can use to determine if edge-to-edge mode is set on Android.

This comment was marked as off-topic.

This comment was marked as off-topic.

@mattleibow
Copy link
Member

@PureWeen was there a reason to use GetInsetsIgnoringVisibility in your OG code?

@KevinJalais
Copy link

Hi all,
I am migrating an app from Xamarin to MAUI and this fix is critical to release the app.
My client is waiting for several graphical bug fixes on MAUI to move on.

Please, can you send some updates about the delay of approval for this bug fix?

@PureWeen
Copy link
Member

Changed the pr a bit, less additional calls and code now. Also, i was thinking about fixing #18033 , but the only way for it to work that i've figured out is to check if the bar's color is Transparent, but i highly doubt the team will let this hack through) Unfortunately there is no such method such as WindowCompat.GetDecorFitsSystemWindows() that we can use to determine if edge-to-edge mode is set on Android.

I think the right fix here is to convert modals to using DialogFragments instead of adding it to the decorView

I spiked that path forever ago
https://github.com/dotnet/maui/tree/dialog_fragment

Not sure if it still compiles :-) but my gut tells me that would just make modals work more naturally overall.

@PureWeen
Copy link
Member

Failing test unrelated

@PureWeen PureWeen merged commit 961f00f into dotnet:main Feb 16, 2024
45 of 47 checks passed
pictos pushed a commit to pictos/maui that referenced this pull request Feb 20, 2024
* Fix modal page push in immersive mode

* Change GetInsetsIgnoringVisibility to GetInsets

* Revert "Fix modal page push in immersive mode"

This reverts commit a2526ea.
rmarinho pushed a commit that referenced this pull request Feb 22, 2024
* Fix modal page push in immersive mode

* Change GetInsetsIgnoringVisibility to GetInsets

* Revert "Fix modal page push in immersive mode"

This reverts commit a2526ea.
rmarinho pushed a commit that referenced this pull request Feb 27, 2024
* Fix modal page push in immersive mode

* Change GetInsetsIgnoringVisibility to GetInsets

* Revert "Fix modal page push in immersive mode"

This reverts commit a2526ea.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Modal Pages do not fill screen when in Fullscreen
7 participants