[iOS] Add iOS17 tests again #19941
Merged
[iOS] Add iOS17 tests again #19941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
platform/iOS 🍎
Area: Platform\Xamarin VS\iOS
and removed
Area: Platform\Xamarin VS\iOS
labels
rmarinho
requested review from
StephaneDelcroix,
tj-devel709,
PureWeen and
BretJohnson
and removed request for
StephaneDelcroix
BretJohnson
previously approved these changes
Feb 1, 2024
PureWeen
reviewed
Feb 7, 2024
| @@ -184,6 +184,7 @@ protected override void Init() | |||
|
|
|||
| #if __IOS__ | |||
| [Test] | |||
| [Ignore("This test fails intermittently, especially on iOS 17; ignore until we can fix it")] | |||
There was a problem hiding this comment.
We should be good now if you want to remove this ignore.
|
/rebase |
…20256) * Add visual test support for multiple devices for a single platform Fixes: #20113 We need this immediately to be able to test both iOS 17.2 on iPhone 15 (the new default) while still testing iOS 16.2 on iPhone X (the old test device). But this is general support that should meet our future needs as more devices are added (at least that's the intention). The comment below explains the scheme: /* Determine the environmentName, used as the directory name for visual testing snaphots. Here are the rules/conventions: - Names are lower case, no spaces. - By default, the name matches the platform (android, ios, windows, or mac). - Each platform has a default device (or set of devices) - if the snapshot matches the default no suffix is needed (e.g. just ios). - If tests are run on secondary devices that produce different snapshots, the device name is used as suffix (e.g. ios-iphonex). - If tests are run on secondary devices with multiple OS versions that produce different snapshots, both device name and os version are used as a suffix (e.g. ios-iphonex-16_4). We don't have any cases of this today but may eventually. The device name comes first here, before os version, because most visual testing differences come from different sceen size (a device thing), not OS version differences, but both can happen. */ * Rename ios -> ios-iphonex directory The ios directory will be replaced with iPhone 15 generated images, as it's the new default. * Update to include deviceName in error messages * Remove the xharness suffix and update iOS test device names * Set DeviceName for Android * Fix cropping on iPhone 15 * Add iPhone 15 snapshots * Ignore FlyoutHeaderWithZeroMarginShouldHaveNoY for now
github-actions
bot
force-pushed
the
add-ios17-again
branch
from
b1d96f2
to
b23b77a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds UITests and Devicestests on iOS17
fixes #19134