[XC] only generate the services that'll be used #19945
Conversation
| @@ -10,6 +10,7 @@ | |||
| namespace Microsoft.Maui.Controls | |||
| { | |||
| /// <include file="../../docs/Microsoft.Maui.Controls/ReferenceTypeConverter.xml" path="Type[@FullName='Microsoft.Maui.Controls.ReferenceTypeConverter']/Docs/*" /> | |||
| [RequireService([typeof(IReferenceProvider), typeof(IProvideParentValues)])] | |||
There was a problem hiding this comment.
this is the only IExtendedTypeConverter that needs to be attributed, all the others have a compiled counterpart
| [AttributeUsage(AttributeTargets.Class, AllowMultiple = true)] | ||
| public sealed class RequireServiceAttribute : Attribute |
There was a problem hiding this comment.
If we add a new API, should this go to .NET 9?
calls for x:Reference and x:StaticResource should produce different IL and no longer push an array with all parents |
|
Somehow it seems a bit slower? I do see IL changes though:
Before:
After:
The most expensive method now is:
Before, I don't think that was showing up as much.
|
|
The part that is concerning is somehow all |
|
Ok, I retested before & after, that latest commit appears to fix what was slow before: Before:
After:
The numbers vary between runs, but I see different IL which should be faster (this is the
|
|
Here is a |
|
/rebase |
github-actions
bot
force-pushed
the
fix_19650
branch
from
32b2065
to
519dec2
Compare
StephaneDelcroix
force-pushed
the
fix_19650
branch
from
4e3b3c7
to
3ba2adc
Compare
samhouts
added
the
area/Xaml </>
StephaneDelcroix
dismissed
simonrozsival’s stale review
The base branch was changed.
|
/rebase |
github-actions
bot
force-pushed
the
fix_19650
branch
from
3ba2adc
to
5591413
Compare
| @@ -243,6 +243,11 @@ | |||
| <data name="XDataTypeSyntax" xml:space="preserve"> | |||
| <value>x:DataType expects a string literal, an {{x:Type}} markup or {{x:Nul}l}.</value> | |||
| </data> | |||
| <data name="UnattributedMarkupType" xml:space="preserve"> | |||
| <value>Consider attributing the markup extension "{0}" with [RequireService] or [AcceptEmptyServiceProvider] if it doesn't require any.</value> | |||
There was a problem hiding this comment.
I created ticket because I think our localization is broken and these aren't getting translated, just a note I wanted to had so we can keep track of it.
MarkupExtensions, ValueProviders and some TypeConverters require a serviceProvider. Only add the services that are actually required. This will reduce IL size, time to JIT, number of allocations, ... Also add a warning when users do not attribute their MarkupExctensions - fixes #19650
StephaneDelcroix
force-pushed
the
fix_19650
branch
from
5591413
to
436514b
Compare
Description of Change
MarkupExtensions, ValueProviders and some TypeConverters require a serviceProvider. Only add the services that are actually required. This will reduce IL size, time to JIT, number of allocations, ...
Also add a warning when users do not attribute their MarkupExctensions
Issues Fixed