Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Keyboards for Prompt #20194

Merged
merged 9 commits into from Feb 16, 2024
Merged

Add new Keyboards for Prompt #20194

merged 9 commits into from Feb 16, 2024

Conversation

pictos
Copy link
Contributor

@pictos pictos commented Jan 27, 2024

Description of Change

This PR adds new Keyboard types:

  • Password
  • Date
  • Time

Issues Fixed

Fixes #9913

@ghost ghost added the community ✨ Community Contribution label Jan 27, 2024
@ghost
Copy link

ghost commented Jan 27, 2024

Hey there @pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz jsuarezruiz added the area-keyboard Keyboard, soft keyboard label Jan 29, 2024
@licon4812
Copy link
Contributor

@pictos I have made a PR on your fork as I was unable to push here. I attempted to add the new keyboards for Tizen

@pictos
Copy link
Contributor Author

pictos commented Jan 29, 2024

@licon4812 thanks for the implementation. Is already merged <3

@licon4812
Copy link
Contributor

@pictos you're too quick 🤣

@pictos pictos marked this pull request as ready for review January 29, 2024 22:37
@pictos pictos requested a review from a team as a code owner January 29, 2024 22:37
@JoonghyunCho
Copy link
Contributor

Oh wow. Looks like Tizen implementation is done thanks to @licon4812.

@jsuarezruiz jsuarezruiz added the t/enhancement ☀️ New feature or request label Feb 2, 2024
@jsuarezruiz
Copy link
Contributor

@rmarinho Should this target the net9.0 branch?

jsuarezruiz
jsuarezruiz previously approved these changes Feb 7, 2024
@rmarinho
Copy link
Member

rmarinho commented Feb 7, 2024

Yeah since this adds API I think we need to only add it on net9.0 @pictos sorry needs rebase :/

@pictos
Copy link
Contributor Author

pictos commented Feb 7, 2024

@rmarinho what should I do then? From the contribution guide I should always target main, is that obsolete?

@rmarinho
Copy link
Member

@pictos I think we need to retarget this to net9.0 and @PureWeen should we update the contrib guide ?

@pictos
Copy link
Contributor Author

pictos commented Feb 12, 2024

@rmarinho which net9?

@rmarinho
Copy link
Member

@pictos https://github.com/dotnet/maui/tree/net9.0

@jsuarezruiz and @PureWeen are going to update the guide thanks for your feedback.

@rmarinho rmarinho changed the base branch from main to net9.0 February 13, 2024 00:38
@rmarinho rmarinho dismissed jsuarezruiz’s stale review February 13, 2024 00:38

The base branch was changed.

@rmarinho rmarinho added the do-not-merge Don't merge this PR label Feb 13, 2024
@pictos
Copy link
Contributor Author

pictos commented Feb 13, 2024

@rmarinho , done

@rmarinho rmarinho merged commit 4a3c485 into dotnet:net9.0 Feb 16, 2024
39 of 42 checks passed
@pictos pictos deleted the pj/new-keyboards branch February 16, 2024 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-keyboard Keyboard, soft keyboard community ✨ Community Contribution do-not-merge Don't merge this PR t/enhancement ☀️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add different input types for prompt
5 participants