Account for margins on sizes returned from Editor #20249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
mattleibow and
rmarinho
and removed request for
a team
mattleibow
reviewed
Jan 31, 2024
samhouts
added
legacy-area-controls
|
UI Test failures are unrelated and being resolved by other PRs |
mattleibow
approved these changes
Feb 5, 2024
rmarinho
approved these changes
Feb 5, 2024
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The Editor control short circuits measuring itself if the user has set EditorAutoSizeOption to Disabled. This ensures that the editor always retains the initial height it was measured with as the user types. The code that was short circuiting the measure wasn't including the margins with the returned size which was causing an infinite loop of confusion as the calling code expected the return value to have margins on it.
Issues Fixed
Fixes #20126
Need to verify if this fixes
#17757