Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C] ColorTypeConverter include alpha when <1 #20414

Merged
merged 1 commit into from Feb 8, 2024
Merged

[C] ColorTypeConverter include alpha when <1 #20414

merged 1 commit into from Feb 8, 2024

Conversation

StephaneDelcroix
Copy link
Contributor

Description of Change

[C] ColorTypeConverter include alpha when <1

Issues Fixed

@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner February 7, 2024 10:32
jsuarezruiz
jsuarezruiz reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could we include a test in ColorTypeConverterTests?

@jsuarezruiz jsuarezruiz added the area-xaml XAML, CSS, Triggers, Behaviors label Feb 7, 2024
@StephaneDelcroix StephaneDelcroix enabled auto-merge (squash) February 8, 2024 10:02
@StephaneDelcroix StephaneDelcroix merged commit 1dc2d46 into main Feb 8, 2024
47 checks passed
@StephaneDelcroix StephaneDelcroix deleted the fix_20411 branch February 8, 2024 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

@Redth Redth Redth approved these changes

@rmarinho rmarinho rmarinho approved these changes

Assignees
No one assigned
Labels
area-xaml XAML, CSS, Triggers, Behaviors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ColorTypeConverter omits alpha channel when converting to string
4 participants
@StephaneDelcroix @Redth @rmarinho @jsuarezruiz