Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Double dash in input field crash fix #20584

Merged
merged 3 commits into from Mar 4, 2024
Merged

[iOS] Double dash in input field crash fix #20584

merged 3 commits into from Mar 4, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Feb 14, 2024 •
edited

Description of Change

Using the length of the text based on the value from the iOS's text input rather than a control. It is because of the system's autocorrection that converts some combinations of characters into other symbols.

Issues Fixed

Fixes #20439
Fixes #19954
Fixes #15937

Before After
crash.mov
fixed.mov

@kubaflo kubaflo requested a review from a team as a code owner February 14, 2024 14:27
@ghost ghost added the community ✨ Community Contribution label Feb 14, 2024
@ghost
Copy link

ghost commented Feb 14, 2024

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

This was referenced Feb 14, 2024
Closed
Closed
Closed
MartyIX
MartyIX reviewed Feb 14, 2024
View reviewed changes
src/Controls/tests/UITests/Tests/Issues/Issue20439.cs
using UITest.Appium;
using UITest.Core;

namespace Microsoft.Maui.AppiumTests.Issues
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file-scoped namespace might be better

@rmarinho
Copy link
Member

/rebase

@github-actions github-actions bot force-pushed the ios-double-dash-in-input-field-crash-fix branch from 0fafc87 to 2be5aad Compare February 19, 2024 13:46
jsuarezruiz
jsuarezruiz reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look to the failing tests? Let me know, If you want me to check them myself.

src/Controls/src/Core/Platform/iOS/Extensions/TextExtensions.cs Show resolved Hide resolved
@jfversluis jfversluis added the s/pr-needs-author-input PR needs an update from the author label Feb 20, 2024
@ghost
Copy link

ghost commented Feb 20, 2024

Hi @kubaflo. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

@kubaflo kubaflo force-pushed the ios-double-dash-in-input-field-crash-fix branch from 2be5aad to 4059c37 Compare February 20, 2024 12:32
@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 20, 2024

@jsuarezruiz Sorry for the late response - I was pretty busy lately :)
I've added a new commit that fixes the tests and the bug

@jsuarezruiz
Copy link
Contributor

@jsuarezruiz Sorry for the late response - I was pretty busy lately :) I've added a new commit that fixes the tests and the bug

Don't worry, thanks for all your contributions. That test are passing now.

@Eilon Eilon added the area/controls 🎮 Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Feb 21, 2024
@rmarinho
Copy link
Member

/azp run MAUI-UITests-public

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rmarinho rmarinho merged commit 6cb942e into dotnet:main Mar 4, 2024
45 of 47 checks passed
@MichaelShapiro MichaelShapiro mentioned this pull request Apr 1, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartyIX MartyIX MartyIX left review comments

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area/controls 🎮 Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor community ✨ Community Contribution platform/iOS 🍎 s/pr-needs-author-input PR needs an update from the author
Projects
None yet
Milestone
No milestone
6 participants
@kubaflo @rmarinho @jsuarezruiz @MartyIX @Eilon @jfversluis