[ci] Enable 1ES PT #20728
Merged
[ci] Enable 1ES PT #20728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
force-pushed
the
enable-esp
branch
2 times, most recently
from
dbf4d40
to
4ed77aa
Compare
Try no pool Extend Add pool try again Use additional artifacts try again additionartifacts parameters again again Publish artifact Update other target path Try new image Use image prop try again update path try artifactsPath missing s Update internal Spot bugs Fix place enable sign Fix identation Fix sign again Try do insertion try again again use parameters again does this one works Clean ufff Try fix sdk insertion try insertion Fix variables try again remove copy paste fix supress sourceRepositoriesToScan nuget-signed add insertion Fix msi fix sourceanalyst fix pool Add suppressionsFile for credScan Fix variable name Add SetupNugetSources.ps1 to CredScan supression Cleanup Add parameters. Fix setup if we fix it don't ignore it Fix internal try move binaries outside nuget Push artifacs on i1esp Disable loc try other pool Fix reference try add apiscan and compliance Try again Only binaries for scan on windows fix path use @self cleanup fix use old way on handlers Fix pack [ci] On Maui we can run less try gndusupress Don't use crescan suppressionsFile
mattleibow
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request includes several changes mainly focused on improving security and updating various aspects of the build process. The changes can be grouped into three categories: security enhancements, updates to the build process, and removal of unused code. Some of the changes are on some arcade files that were just updated to latest version from main branch from that repo.
Security Enhancements:
eng/automation/guardian/CredScanSuppressions.json: Removed this file which contained dummy files used for testing.eng/common/SetupNugetSources.ps1: Updated thePasswordparameter to useSecureStringin several functions to enhance security. [1] [2] [3] [4]Updates to the Build Process:
eng/automation/guardian/source.gdnsuppress: Added a new signature to the file.eng/common/tools.ps1andeng/common/tools.sh: Made several changes to update the build process, including updating the minimum required version of Visual Studio, changing the package used for MSBuild, and updating the .NET Framework version used. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]Removal of Unused Code:
eng/common/tools.ps1: Removed unused code related to theDotNetCoreSdkDirenvironment variable andDOTNET_SKIP_FIRST_TIME_EXPERIENCEenvironment variable. [1] [2]eng/common/tools.sh: Removed unused code related tonetcoreapp2.1andnetcoreapp3.1.