Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of feature switches in Debug mode #20748

Merged
merged 1 commit into from Feb 22, 2024
Merged

Fix usage of feature switches in Debug mode #20748

merged 1 commit into from Feb 22, 2024

Conversation

simonrozsival
Copy link
Member

Description of Change

The _MauiPrepareForILLink target ran after the runtimeconfig.json file was generated and so the AppContext.TryGetSwtich could not find the feature value.

Issues Fixed

Fixes #20747

@simonrozsival simonrozsival requested a review from a team as a code owner February 21, 2024 15:43
@rmarinho rmarinho merged commit 6307828 into dotnet:net9.0 Feb 22, 2024
40 of 46 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonrozsival @rmarinho