iOS Shell TitleView Update Height #20795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tj-devel709
added
platform/iOS 🍎
area/shell 🐢
jsuarezruiz
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If you change the constraints on iOS Shell TitleView, the height was not getting updated correctly. Currently, the LayoutSubviews is calling to update the frame only once, but since the issue in question is updating the height again, it was not getting processed.
Now on first loading the screen, the TitleView has the expected height above the tabs as such:
Testing
You can test this change on this branch: https://github.com/dotnet/maui/tree/dev/TJ/TitleViewHeight2-PRTesting and observe that the TitleView covers the entire height.
Issues Fixed
Fixes #18060