Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image loading tests #20955

Merged
merged 4 commits into from Mar 3, 2024
Merged

Fix image loading tests #20955

merged 4 commits into from Mar 3, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Mar 1, 2024

Description of Change

We're hitting an issue with image verifications on this test where the scrollbars are sometimes showing up and sometimes not.

I've added some code to force the scrollbars to always show up. Currently I'm not sure if the scrollbars not showing up is an actual measuring bug or just a quirk from running on different systems.

If this passes, let's merge it up to main. If it stays passing on main then we can formalize this fix a bit more

@PureWeen PureWeen marked this pull request as ready for review March 2, 2024 00:17
@PureWeen PureWeen requested a review from a team as a code owner March 2, 2024 00:17
@PureWeen PureWeen merged commit 4973dc9 into main Mar 3, 2024
43 of 47 checks passed
@PureWeen PureWeen deleted the fix_image_loading_tests branch March 3, 2024 02:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant