[Android] Border with RoundRectangle - fix #21250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
jsuarezruiz
and removed request for
StephaneDelcroix
|
This also fixes this issue #19877 
|
dotnet-policy-service
bot
added
the
legacy-area-controls
|
Added pending test snapshots except on Windows where the test has not been run. Running it again. |
jsuarezruiz
previously approved these changes
May 9, 2024
jsuarezruiz
previously approved these changes
May 9, 2024
Eilon
removed
the
legacy-area-controls
# Conflicts: # src/Controls/tests/TestCases.Android.Tests/snapshots/android/BorderRoundRectangleWithImage.png # src/Controls/tests/TestCases.Android.Tests/snapshots/android/BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt.png # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19877.cs # src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21173.cs # src/Controls/tests/TestCases/Issues/Issue19877.xaml # src/Controls/tests/TestCases/Issues/Issue19877.xaml.cs # src/Controls/tests/TestCases/Issues/Issue21173.xaml # src/Controls/tests/TestCases/Issues/Issue21173.xaml.cs
|
Thanks for this PR! Been a long while, so I rebased because we should have reviewed a bit sooner... |
mattleibow
approved these changes
Jun 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #21173
Fixes #19877