[Android] Fixed box view properties #21322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
|
/azp run MAUI-UITests-public |
Hey Rui, do you know why the UITest task is not running in this case? |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PureWeen
requested changes
Mar 22, 2024
rmarinho
reviewed
Mar 25, 2024
| @@ -64,7 +64,7 @@ protected override void OnPropertyChanged([CallerMemberName] string? propertyNam | |||
|
|
|||
| PathAspect IShapeView.Aspect => PathAspect.None; | |||
|
|
|||
| Paint? IShapeView.Fill => Color?.AsPaint() ?? ((IView)this).Background; | |||
| Paint? IShapeView.Fill => Color?.AsPaint(); | |||
There was a problem hiding this comment.
I don't understand how this fixes it ,
There was a problem hiding this comment.
@rmarinho I've noticed that the box view is rendered twice. It is easy to observe when setting the translationY property to 200. This is the outcome:
With this ((IView)this).Background part removed from the code the shapeViewHandler doesn't update the background and therefore does not draw that top right boxView
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Apr 10, 2024
| this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.iOS, TestDevice.Mac, TestDevice.Windows }); | ||
| _ = App.WaitForElement("boxView"); | ||
|
|
||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Added pending snapshot.
|
/azp run |
PureWeen
approved these changes
Apr 12, 2024
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-19926
branch
from
1520c14
to
d3f6d8f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Eilon
added
area-controls-boxview
area-drawing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The properties of BoxView haven't been automatically applied. Only when modified in the code after being initialized the changes be applied. It could be also replicated with a hot reload.
Issues Fixed
Fixes #19926