New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Make window overlay to redraw correctly during window resizing #21371
[macOS] Make window overlay to redraw correctly during window resizing #21371
Conversation
Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, tested here didn't saw nothing bad. but @drasticactions maybe is a better one to give the 2nd thumbs up.
Adding a test would be great.
A test would require resizing a window. I'm not sure how stable that would be (MacCatalyst supports setting max/min width&height, not with & height; there is a workaround but still). But I think I can try. Ideas for approaching the test are welcome. |
@mattleibow can't we set the window size via API? I wonder if we can write a UITEst that uses that api and then checks if the adorner changed position |
I have just realized this PR might depend on #21357 to add a proper test. |
Description of Change
The following videos demonstrate the issue and the fixex behavior (hopefully):
Current master:
Screen.Recording.2024-03-21.at.19.45.39.mov
With the PR:
Screen.Recording.2024-03-21.at.19.38.27.mov
Issues Fixed
Fixes #21307