Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Make window overlay to redraw correctly during window resizing #21371

Merged

Conversation

MartyIX
Copy link
Collaborator

@MartyIX MartyIX commented Mar 21, 2024

Description of Change

The following videos demonstrate the issue and the fixex behavior (hopefully):

Current master:

Screen.Recording.2024-03-21.at.19.45.39.mov

With the PR:

Screen.Recording.2024-03-21.at.19.38.27.mov

Issues Fixed

Fixes #21307

@MartyIX MartyIX requested a review from a team as a code owner March 21, 2024 18:48
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 21, 2024
Copy link
Contributor

Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@MartyIX
Copy link
Collaborator Author

MartyIX commented Mar 21, 2024

cc @drasticactions

@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, tested here didn't saw nothing bad. but @drasticactions maybe is a better one to give the 2nd thumbs up.

Adding a test would be great.

@MartyIX
Copy link
Collaborator Author

MartyIX commented Mar 22, 2024

A test would require resizing a window. I'm not sure how stable that would be (MacCatalyst supports setting max/min width&height, not with & height; there is a workaround but still).

But I think I can try. Ideas for approaching the test are welcome.

@rmarinho
Copy link
Member

rmarinho commented Mar 22, 2024

@mattleibow can't we set the window size via API? I wonder if we can write a UITEst that uses that api and then checks if the adorner changed position

@MartyIX
Copy link
Collaborator Author

MartyIX commented Mar 23, 2024

@mattleibow can't we set the window size via API? I wonder if we can write a UITEst that uses that api and then checks if the adorner changed position

I have just realized this PR might depend on #21357 to add a proper test.

@rmarinho rmarinho merged commit d656c4e into dotnet:main Mar 27, 2024
47 checks passed
@MartyIX MartyIX deleted the feature/2024-03-21-macOS-overlay-resizing branch March 27, 2024 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-window Window community ✨ Community Contribution platform/macOS 🍏 macOS / Mac Catalyst
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] IWindowOverlayElement.Draw dirtyRect only returns initial Window Size.
4 participants