Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for WebView Error when changing page with WebView loading a page #21436

Merged
merged 1 commit into from Mar 27, 2024

Conversation

dustin-wojciechowski
Copy link
Contributor

Description of Change

Ensure that SetContextMenuConfiguration always calls the completion handler and not just when a MauiUIContextMenuInteraction's configuration is found.

Issues Fixed

Fixes #20627

@dustin-wojciechowski dustin-wojciechowski requested a review from a team as a code owner March 25, 2024 19:36
@dotnet-policy-service dotnet-policy-service bot added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 25, 2024
@rmarinho
Copy link
Member

Humm, seems it causes this test to fail..

HandlerDoesNotLeak  - Microsoft_Maui_Platform_MauiWKWebView

@rmarinho rmarinho merged commit 705b551 into main Mar 27, 2024
47 checks passed
@rmarinho rmarinho deleted the dev/dustinw/fix-webview-error branch March 27, 2024 11:18
@dustin-wojciechowski
Copy link
Contributor Author

@rmarinho Is that leak related to #18985?

@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebView error if we leave page while it's navigating
4 participants