fix issue in orientation of images #21458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
reviewed
Mar 27, 2024
| } | ||
|
|
||
| return image; | ||
| } | ||
|
|
||
| static UIImageOrientation ToUIImageOrientation (CGImageSource cgImageSource) |
There was a problem hiding this comment.
The code format is not quite right :) seems mono days? we provide the rules in a .editorconfig..
Our dotnet format on this file only will also work.
|
Will this be a breaking change? Like before images will always appear UP and now can show in a different orientation? Should we target this only to net9 ? |
dotnet-policy-service
bot
added
the
legacy-area-controls
Not really, no. It restores correct behavior that was in place before February 16th. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 21458 in repo dotnet/maui |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 21458 in repo dotnet/maui |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
previously approved these changes
Apr 13, 2024
|
/rebase |
github-actions
bot
force-pushed
the
image-orientation
branch
from
bd19057
to
40b3a74
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Apr 14, 2024
|
Test failures unrelated |
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added code to retrieve image orientation from the metadata, translate it and apply it to the image constructor.
Issues Fixed
Fixes #21314
In brief, pull the image properties from the
CGImageSourceand translate it to the values for the UIImage constructor.The conversion code was based on this documentation from Apple.