Add an API to allow registering TypeConverters for third-party types #21476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
requested review from
StephaneDelcroix and
jonathanpeppers
and removed request for
jfversluis
jonathanpeppers
previously approved these changes
Mar 28, 2024
mattleibow
reviewed
Mar 28, 2024
| { | ||
| public static class TypeConversionAppBuilderExtensions | ||
| { | ||
| private static Dictionary<Type, TypeConverter>? s_typeConverters; |
There was a problem hiding this comment.
Not sure if we can help it with various callers, but if this is static, the tests will have issues because multiple builder tests run in parallel - and each creates a new builder.
Is there a way to put this list into the service collection?
There was a problem hiding this comment.
I was trying to figure this out but in the end I just gave up. The alternative I was considering was registering it as a service and then accessing it from the static TypeConversion class via Application.Current?.FindMauiContext() which we seem to often use for logging. I'm not sure if that solves the problem though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a follow-up to #21050 and #21459
This PR re-introduces an API that should serve as an escape hatch for developers migrating to NativeAOT who will run into problems with missing implicit operators. For their custom types, they can use the
[TypeConverter]attribute, but for third-party types, there isn't a suitable mechanism.This new API would allow registering type converters through the MauiAppBuilder.
Issues Fixed
Contributes to #19397
/cc @mattleibow