Don't worry about the size of the text #21628
Merged
+149
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Apr 4, 2024
src/Controls/src/Core/Platform/Android/Extensions/ButtonExtensions.cs
Outdated
Show resolved
Hide resolved
PureWeen
commented
Apr 4, 2024
| // Because this resolves from a task we should validate that the | ||
| // handler hasn't been disconnected | ||
| if (handler.IsConnected()) | ||
| handler.UpdateValue(nameof(IImage.IsAnimationPlaying)); |
There was a problem hiding this comment.
This was occasionally causing a crash in our device tests.
Also, I don't think we ever should have used ContinueWith here, I don't think ContinueWith will resolve on the synchronization context. I'm pretty sure the code inside ContinueWith will be on a task pool thread unless you pass TaskScheduler.FromCurrentSynchronizationContext()
mattleibow
reviewed
Apr 4, 2024
src/Controls/src/Core/Platform/Android/Extensions/ButtonExtensions.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Platform/Android/Extensions/ButtonExtensions.cs
Outdated
Show resolved
Hide resolved
PureWeen
force-pushed
the
try_removing_text_measure
branch
from
05078ba
to
32698e2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
approved these changes
Apr 5, 2024
|
The code looks good. It all seems reasonable and flows logically. I have not yet tested the actual code on a device/emulator. We probably need to throw in a UI test that updates the location of the image or shows/hides the image. I recall there were "update" issues as well. I think the current UI tests are just testing initial states. |
|
Failing tests unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
After internal conversations and for the purposes of staying consistent with SR3 we're going to take the route of always letting the image take priority over the text for placement. There's not really a best way to determine the ratio to scale the image to when you have really long text. So, when the user hits a scenarios where the image is just too big for a constrained button it's the users responsibility to resize the physical image themselves. This is ultimately better for performance as well.