[XC] compile OnIdiom #21799
Draft
[XC] compile OnIdiom #21799
+209
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile OnIdiom markup extension. Doing that we can infer the type of the ProvidedValue instead of using Object - fixes #18697
|
as draft for now. have to look at what happen with valuetypes, and think about sending warning if the different idiom types doesn't match |
| methodName: "op_Equality", | ||
| parameterTypes: new[] { ("Microsoft.Maui.Essentials", "Microsoft.Maui.Devices", "DeviceIdiom"), ("Microsoft.Maui.Essentials", "Microsoft.Maui.Devices", "DeviceIdiom") }, | ||
| isStatic: true))); | ||
| instructions.Add(Create(Brfalse, instr_getDefault)); |
There was a problem hiding this comment.
Is this correct? Wouldn't this jump to the getDefault branch if the first idiom doesn't match the idiom, effectively skipping over all the other cases?
Comment on lines
+42
to
+47
| var idiomTypeRef = (idiom.Value as IElementNode).XmlType.GetTypeReference(context.Cache, module, node as IXmlLineInfo); | ||
| if (TypeRefComparer.Instance.Compare(memberRef, idiomTypeRef) != 0) | ||
| { | ||
| //should this issue a warning? | ||
| memberRef = module.TypeSystem.Object; | ||
| } |
There was a problem hiding this comment.
I'm worried this comparison is too strict, especially when comparing ints and doubles (e.g., Phone=0, Tablet=2.5). Would it be possible to try to find the "lowest common denominator" between all the types instead of immediately fall back to object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Compile OnIdiom markup extension. Doing that we can infer the type of the ProvidedValue instead of using Object
Issues Fixed