Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blazor] Reacts to SDK and Runtime updates and adds support for click-once deployments in WPF and Winforms apps #2187

Merged
merged 6 commits into from
Aug 20, 2021
Merged

[Blazor] Reacts to SDK and Runtime updates and adds support for click-once deployments in WPF and Winforms apps #2187

merged 6 commits into from
Aug 20, 2021

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Aug 20, 2021 •
edited

  • Reenables static web assets on disabled projects.
  • Removes unnecessary workaround for Blazor and Maui.
  • Adds support for ClickOnce publishing in Blazor Webforms and WPF apps.

@javiercn javiercn requested a review from Eilon August 20, 2021 13:10
@javiercn javiercn force-pushed the javiercn/static-web-assets-cleanups branch from 1b56f0f to c0400b2 Compare August 20, 2021 13:11
@javiercn javiercn force-pushed the javiercn/static-web-assets-cleanups branch from 6eb1b1d to f911745 Compare August 20, 2021 13:54
Eilon
Eilon approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

1 tiny new comment here, plus our chat about manually including the new targets in the 2 sample projects.

...rWebView/src/WindowsForms/build/Microsoft.AspNetCore.Components.WebView.WindowsForms.targets Outdated Show resolved Hide resolved
@Eilon Eilon merged commit 50999f6 into main Aug 20, 2021
@Eilon Eilon deleted the javiercn/static-web-assets-cleanups branch August 20, 2021 18:15
@Eilon Eilon mentioned this pull request Sep 1, 2021
Closed
@samhouts samhouts added area-blazor Blazor Hybrid / Desktop, BlazorWebView area-controls-webview WebView labels Jul 10, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Eilon Eilon Eilon approved these changes

Assignees
No one assigned
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView area-controls-webview WebView
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@javiercn @Eilon @samhouts