[Android] Geolocation IsListeningForeground property is always false #21919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know when this could be merged? We'd love to have this available for our business ❤️ |
|
Hi, it would be very useful for my project too. |
jsuarezruiz
added
platform/android 🤖
area-essentials
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi guys, with any luck, could someone look into the failed jobs to push this PR a bit further? The failed tests seem unrelated to the PR itself: given that the change only applies to Android platform and the failed tests aren't. |
|
Yeah that would also be useful for my project. |
|
Added device test. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@dotnet-policy-service agree |
|
Thank's for adding a test @jsuarezruiz ! 😄 |
PureWeen
approved these changes
May 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove the var keyword so the targetted continousListener is the static one inside the class instead of a local variable
maui/src/Essentials/src/Geolocation/Geolocation.android.cs
Line 181 in d3335ad
continuousListener is always null, that causes the property IsListeningInForeground to be always false and making it impossible to Stop the listener
Issues Fixed
Fixes #21439