[android] fix design-time build on project creation #22559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#21777 (comment) When creating a new .NET MAUI project, the first design-time build can randomly fail with: C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\34.0.95\tools\Xamarin.Android.Common.targets(613,3): error XA1018: Specified AndroidManifest file does not exist: D:\source\MauiApp3\MauiApp3\AndroidManifest.xml. This can happen because: 1. NuGet restore isn't complete 2. `Microsoft.Maui.Controls.SingleProject.targets` is not imported 3. `$(AndroidManifest)` has not been moved to `Platforms/Android/AndroidManifest.xml` This means the Android workload would just look for `AndroidManifest.xml` in the root of the project, which doesn't exist. To fix this, let's check for the non-existence of `$(AndroidManifest)` in the workload and set it. After testing this change in: * `C:\Program Files\dotnet\packs\Microsoft.Maui.Sdk\8.0.21\Sdk\Microsoft.Maui.Sdk.After.targets` I don't get a design-time build failure anymore.
jonathanpeppers
requested review from
StephaneDelcroix,
jfversluis and
mattleibow
Eilon
added
the
area-tooling
jsuarezruiz
approved these changes
May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21777 (comment)
When creating a new .NET MAUI project, the first design-time build can randomly fail with:
This can happen because:
NuGet restore isn't complete
Microsoft.Maui.Controls.SingleProject.targetsis not imported$(AndroidManifest)has not been moved toPlatforms/Android/AndroidManifest.xmlThis means the Android workload would just look for
AndroidManifest.xmlin the root of the project, which doesn't exist.To fix this, let's check for the non-existence of
$(AndroidManifest)in the MAUI workload and set it.After testing this change in:
C:\Program Files\dotnet\packs\Microsoft.Maui.Sdk\8.0.21\Sdk\Microsoft.Maui.Sdk.After.targetsI don't get a design-time build failure anymore.
/cc @BethMassi