Fixes endless loop of HorizontalScroll #22628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @BaY1251! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Jun 4, 2024
| @@ -214,7 +214,7 @@ protected override void OnLayout(bool changed, int left, int top, int right, int | |||
| { | |||
| base.OnLayout(changed, left, top, right, bottom); | |||
|
|
|||
| if (_hScrollView?.Parent == this && _content is not null) | |||
| if (changed && _hScrollView?.Parent == this && _content is not null) | |||
There was a problem hiding this comment.
The issue still happens after merge #22347?
There was a problem hiding this comment.
PR22347 has fixed this issue and performed very well.
This PR attempts to solve the problem from another perspective, that is, the _hScrollView should not be adjusted when 'changed' is' false '.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I know PR #22347 has fixed #20684. But,I am still searching for the root cause of the problem.
I printed the log and saw that the height was constantly being changed to completely different values.
I think MauiScrollView.OnLayout is where the modifications should be made.
Change \src\Core\src\Platform\Android\MauiScrollView.cs
Log:
#22566 (comment)
Issues Fixed
Fixes #20684