Fixing _loaded event firing logic #22807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @rafalka! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@rafalka can you add a unit test for this? https://github.com/dotnet/maui/blob/main/src/Controls/tests/Core.UnitTests/PageLifeCycleTests.cs |
|
@dotnet-policy-service agree |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested review from
jsuarezruiz
and removed request for
tj-devel709
jsuarezruiz
added
the
area-core-lifecycle
mattleibow
approved these changes
Jun 4, 2024
|
Please have a look at this issue CommunityToolkit/Maui#1931 and how that can be solved. Looks like this fix does some strange things when the Unloaded event is not set on the page and Loaded is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes obvious mistake in
VisualElement.Loadedevent handling which causes firing this event twiceIssues Fixed
Fixes #22740