Fix Appium install PowerShell script #22883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
t/housekeeping ♻︎
area-infrastructure
jsuarezruiz
reviewed
Jun 6, 2024
| if (Test-Path $AppiumHome) { | ||
| Write-Output "Removing existing APPIUM_HOME Cache..." | ||
| Remove-Item -Path $AppiumHome -Recurse -Force | ||
| if ($AppiumHome) { |
There was a problem hiding this comment.
Should use Write-Output indicating that needs to set the APPIUM_HOME if is null?
There was a problem hiding this comment.
I think the point here is that it tries to find Appium and if it doesn't find it or its not the version we expect then its going to uninstall and install: https://github.com/dotnet/maui/pull/22883/files#diff-2d6fe919f8e6585ce7f9aa99776ffc5fe0e737205eca6b3cf0a5ab6576a42870R90
This check only make sure that the script doesn't crash on a null reference exception when its not installed
jsuarezruiz
approved these changes
Jun 7, 2024
rmarinho
approved these changes
Jun 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The PowerShell script would check if APPIUM_HOME is set, but when its not and returns null, the subsequent
Test-Pathwould throw a null reference exception.