Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Wire up text for SearchBar and Editor #2454

Merged
merged 10 commits into from Sep 11, 2021

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Sep 10, 2021

Description of Change

  • Fixes Editor and SearchBar so they propagate native changes to xplat elements
  • Standarize the UnitTests for testing ITextInput related properties so we can make sure to run the same set of tests across all things implementing ITextInput
  • Where possible converted to using event subscriptions over listeners. This will let users also subscribe to those events without wiping our our listeners

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

fixes #2712

@PureWeen PureWeen merged commit 85b5699 into main Sep 11, 2021
@PureWeen PureWeen deleted the fix_searchbar_editor_text branch September 11, 2021 12:55
@Redth Redth added this to the 6.0.101-preview.9 milestone Sep 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SearchCommand not working in Android
4 participants